linux-kernel - Re: [PATCH] w1-gpio: add external pull-up enable callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 May 2009 21:19:24 +0300
From:	Ville Syrjälä <syrjala@....fi>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] w1-gpio: add external pull-up enable callback

On Thu, May 07, 2009 at 03:30:32AM +0200, Daniel Mack wrote:
> On Wed, May 06, 2009 at 11:28:18PM +0300, Ville Syrjälä wrote:
> > > > > This patch adds a callback function pointer to let users switch on and
> > > > > off the external pull-up resistor. This lets the outside world know
> > > > > whether the processor is currently actively driving the bus or not.
> > > > 
> > > > Looks simple enough but I wonder if you could just do this from the
> > > > platform code. I suppose the downside would be that you would enable the
> > > > pullup even if w1-gpio is not loaded.
> > > 
> > > That's right. Hence I put it where I believe it belongs to.
> > 
> > Well, if you think you need it who am I to argue :)
> > 
> > Acked-by: Ville Syrjälä <syrjala@....fi>
> 
> Thanks :)

BTW you should probably send this via Evgeniy Polyakov if you want it
included in the kernel at some point.

-- 
Ville Syrjälä
syrjala@....fi
http://www.sci.fi/~syrjala/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/