linux-kernel - [PATCH 1/2] Input: tsc2007: fix locking method against the current rc kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 May 2009 20:41:35 +0900
From:	Kwangwoo Lee <kwangwoo.lee@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	Trilok Soni <soni.trilok@...il.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: [PATCH 1/2] Input: tsc2007: fix locking method against the current rc 
	kernel

Hi Dmitry,

The following patch fixes bug in tsc2007.
It is not working correctly in the current rc kernels.
IMHO, this patch should go in the 2.6.30

Can you advise me about "From: email" part?
I splited Thierry's patch. So the original "From: email" is followed:

From: Thierry Reding <thierry.reding@...onic-design.de>

Thank you,
Kwangwoo Lee

>From 749ee3a4a2c2fe1f41601481e47cb26d8ccec20d Mon Sep 17 00:00:00 2001
From: Kwangwoo Lee <kwangwoo.lee@...il.com>
Date: Mon, 11 May 2009 20:00:01 +0900
Subject: [PATCH 1/2] Input: tsc2007: fix locking method against the
current rc kernel.

Without this patch, current driver will emit panic message below:
Kernel panic - not syncing: Fatal exception in interrupt.

The original patch is written by Thierry.

Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de>
Signed-off-by: Kwangwoo Lee <kwangwoo.lee@...il.com>
---
 drivers/input/touchscreen/tsc2007.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/tsc2007.c
b/drivers/input/touchscreen/tsc2007.c
index 536668f..948e167 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -200,8 +200,9 @@ static int tsc2007_read_values(struct tsc2007 *tsc)
 static enum hrtimer_restart tsc2007_timer(struct hrtimer *handle)
 {
 	struct tsc2007 *ts = container_of(handle, struct tsc2007, timer);
+	unsigned long flags;

-	spin_lock_irq(&ts->lock);
+	spin_lock_irqsave(&ts->lock, flags);

 	if (unlikely(!ts->get_pendown_state() && ts->pendown)) {
 		struct input_dev *input = ts->input;
@@ -222,7 +223,7 @@ static enum hrtimer_restart tsc2007_timer(struct
hrtimer *handle)
 		tsc2007_send_event(ts);
 	}

-	spin_unlock_irq(&ts->lock);
+	spin_unlock_irqrestore(&ts->lock, flags);

 	return HRTIMER_NORESTART;
 }
-- 
1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/