linux-kernel - Re: [PATCH 7/7] x86/pci: update pirq_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 May 2009 09:49:13 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Len Brown <lenb@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH 7/7] x86/pci: update pirq_enable_irq to setup io apic
	routing -v2


* Jesse Barnes <jbarnes@...tuousgeek.org> wrote:

> On Thu, 7 May 2009 16:12:22 +0200
> Ingo Molnar <mingo@...e.hu> wrote:
> 
> > 
> > * Yinghai Lu <yinghai@...nel.org> wrote:
> > 
> > > 
> > > so we could set io apic routing only when enable device irq.
> > > 
> > > also could make setup_IO_APIC_irqs and setup_ioapic_dest only handle
> > > first ioapic...
> > > 
> > > v2: remove one one not needed style change.
> > >     merge the patch only setup io_apic for acpi on in
> > > setup_IO_APIC_irqs
> > > 
> > > [ Impact: make mptable irq enable more like acpi is used, and
> > > numa_irq_desc could get correct node when acpi=off ]
> > > 
> > > Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> > > 
> > > ---
> > >  arch/x86/kernel/apic/io_apic.c |  148
> > > ++++++++++++++++++++---------------------
> > > arch/x86/pci/irq.c             |   84 ++++++++--------------- 2
> > > files changed, 103 insertions(+), 129 deletions(-)
> > 
> > Jesse, did this patch have your Acked-by?
> 
> Yeah, both of them are fine with me.  Ultimately you get to keep 
> any broken pieces from io_apic changes anyway, right? :)

Yeah, generally. But the wider the blame can be spread when it does 
break, the better! ;-)

> Acked-by: Jesse Barnes <jbarnes@...tuousgeek.org>

Thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/