linux-kernel - Re: [PATCH v2] x86: fix ktermios-termio conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2009 12:15:14 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Arnd Bergmann <arnd@...db.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Remis Lima Baima <remis.developer@...glemail.com>
Subject: Re: [PATCH v2] x86: fix ktermios-termio conversion


* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> > My argument was very simple: the patch causes +150 bytes of 
> > bloat. The try/ex/catch method can help reduce register pressure 
> > and can reducethe size of code quite visibly.
> 
> My argument is even simpler - its not worth the effort in the 
> first place.
> 
> I'm sure you could use the same time to shave 150 bytes and a few 
> clocks of a path that actually gets executed.

This is about kernel image size as well. This version of the patch 
bloats the kernel. The death of a thousand cuts ...

> Arnd - can you send me a diff that keeps the existing horrible 
> macro version, the existing __put_user usage and just fixes c_line 
> ? It's worked for 15 years, its not worth the time being fancy 
> with it.

Agreed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/