linux-kernel - Re: [PATCH block#for-2.6.31] scsi: fix resid_len mis-conversion in scsi_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 May 2009 20:31:31 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	tj@...nel.org
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	jens.axboe@...cle.com, James.Bottomley@...senPartnership.com,
	bharrosh@...asas.com, fujita.tomonori@....ntt.co.jp
Subject: Re: [PATCH block#for-2.6.31] scsi: fix resid_len mis-conversion in
 scsi_end_request()

On Tue, 12 May 2009 11:15:22 +0900
Tejun Heo <tj@...nel.org> wrote:

> Commit c3a4d78c580de4edc9ef0f7c59812fb02ceb037f introduced
> rq->data_len and converted residual count users to it.  While
> converting, it mistakenly converted scsi_end_request() to finish
> requests with residual count when it wants to do is fully complete the
> request.  Fix it by using blk_end_request_all() instead.
> 
> This bug was spotted by Boaz Harrosh.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Spotted-by: Boaz Harrosh <bharrosh@...asas.com>
> Cc: Jens Axboe <jens.axboe@...cle.com>
> Cc: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> Cc: James Bottomley <James.Bottomley@...senPartnership.com>
> ---
>  drivers/scsi/scsi_lib.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/