linux-kernel - Re: [PATCH 10/10 -tip] x86: collect_cpu_info() of AMD user of Microcode feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 May 2009 07:47:21 +0200
From:	Andreas Herrmann <andreas.herrmann3@....com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
CC:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...nel.org>,
	Robert Richter <robert.richter@....com>,
	Dave Jones <davej@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	x86 maintainers <x86@...nel.org>
Subject: Re: [PATCH 10/10 -tip] x86: collect_cpu_info() of AMD user of
	Microcode feature

On Tue, May 12, 2009 at 09:14:38PM +0530, Jaswinder Singh Rajput wrote:
> 
> use X86_FEATURE_MICROCODE to determine microcode update
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>

NAK.

>  arch/x86/kernel/microcode_amd.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
> index 453b579..1178638 100644
> --- a/arch/x86/kernel/microcode_amd.c
> +++ b/arch/x86/kernel/microcode_amd.c
> @@ -90,7 +90,8 @@ static int collect_cpu_info_amd(int cpu, struct cpu_signature *csig)
>  	u32 dummy;
>  
>  	memset(csig, 0, sizeof(*csig));
> -	if (c->x86_vendor != X86_VENDOR_AMD || c->x86 < 0x10) {
> +	if (c->x86_vendor != X86_VENDOR_AMD ||
> +	    !cpu_has(c, X86_FEATURE_MICROCODE)) {
>  		printk(KERN_WARNING "microcode: CPU%d: AMD CPU family 0x%x not "
>  		       "supported\n", cpu, c->x86);
>  		return -1;
> -- 
> 1.6.0.6


Regards,
Andreas

-- 
Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/