linux-kernel - Re: [PATCH] Kconfig: CONFIG_UNEVICTABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 May 2009 17:51:52 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>,
	Minchan Kim <minchan.kim@...il.com>
Subject: Re: [PATCH] Kconfig: CONFIG_UNEVICTABLE_LRU move into EMBEDDED
 submenu

Hi, Kosaki. 

On Wed, 13 May 2009 17:30:45 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> Subject: [PATCH] Kconfig: CONFIG_UNEVICTABLE_LRU move into EMBEDDED submenu
> 
> Almost people always turn on CONFIG_UNEVICTABLE_LRU. this configuration is
> used only embedded people.

I think at least embedded guys don't need it. 
But I am not sure other guys. 

> Thus, moving it into embedded submenu is better.
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> Cc: Lee Schermerhorn <Lee.Schermerhorn@...com>
> Cc: Minchan Kim <minchan.kim@...il.com>
> ---
>  init/Kconfig |   12 ++++++++++++
>  mm/Kconfig   |   12 ------------
>  2 files changed, 12 insertions(+), 12 deletions(-)
> 
> Index: b/mm/Kconfig
> ===================================================================
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -203,18 +203,6 @@ config VIRT_TO_BUS
>  	def_bool y
>  	depends on !ARCH_NO_VIRT_TO_BUS
>  
> -config UNEVICTABLE_LRU
> -	bool "Add LRU list to track non-evictable pages"
> -	default y
> -	help
> -	  Keeps unevictable pages off of the active and inactive pageout
> -	  lists, so kswapd will not waste CPU time or have its balancing
> -	  algorithms thrown off by scanning these pages.  Selecting this
> -	  will use one page flag and increase the code size a little,
> -	  say Y unless you know what you are doing.
> -
> -	  See Documentation/vm/unevictable-lru.txt for more information.
> -
>  config HAVE_MLOCK
>  	bool
>  	default y if MMU=y
> Index: b/init/Kconfig
> ===================================================================
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -954,6 +954,18 @@ config SLUB_DEBUG
>  	  SLUB sysfs support. /sys/slab will not exist and there will be
>  	  no support for cache validation etc.
>  
> +config UNEVICTABLE_LRU
> +	bool "Add LRU list to track non-evictable pages" if EMBEDDED
> +	default y

If you want to move, it would be better as following.

config UNEVICTABLE_LRU
       bool "Add LRU list to track non-evictable pages" if EMBEDDED
       default !EMBEDDED

For embedded, it is disabled by default. 

> +	help
> +	  Keeps unevictable pages off of the active and inactive pageout
> +	  lists, so kswapd will not waste CPU time or have its balancing
> +	  algorithms thrown off by scanning these pages.  Selecting this
> +	  will use one page flag and increase the code size a little,
> +	  say Y unless you know what you are doing.
> +
> +	  See Documentation/vm/unevictable-lru.txt for more information.
> +
>  config STRIP_ASM_SYMS
>  	bool "Strip assembler-generated symbols during link"
>  	default n
> 
> 


-- 
Kinds Regards
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/