linux-kernel - Re: [PATCH] mb862xxfb: use CONFIG_OF instead of CONFIG_PPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 May 2009 14:25:27 +0200
From:	Anatolij Gustschin <agust@...x.de>
To:	Arnd Bergmann <arnd@...db.de>
CC:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] mb862xxfb: use CONFIG_OF instead of CONFIG_PPC_OF

Arnd Bergmann wrote:

> With this change, the driver builds fine on Microblaze, which
> helps allyesconfig compile tests.

This patch is okay, just tested it. So
Acked-by: Anatolij Gustschin <agust@...x.de>

> I did not test sparc, but the change should have the same effect there.

unfortunately, OF platform part of this driver doesn't build on sparc
as there is no of_address_to_resource() and no NO_IRQ in sparc code.
There was an attempt to fix it by restricting the build of this part
to PPC, see http://lkml.org/lkml/2009/1/11/376

I will rebase the above mentioned patch by Julian Calaby and resubmit
soon. Thanks.

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/video/mb862xx/mb862xxfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/mb862xx/mb862xxfb.c 
> b/drivers/video/mb862xx/mb862xxfb.c
> index fb64234..a28e3cf 100644
> --- a/drivers/video/mb862xx/mb862xxfb.c
> +++ b/drivers/video/mb862xx/mb862xxfb.c
> @@ -19,7 +19,7 @@
>  #include <linux/init.h>
>  #include <linux/interrupt.h>
>  #include <linux/pci.h>
> -#if defined(CONFIG_PPC_OF)
> +#if defined(CONFIG_OF)
>  #include <linux/of_platform.h>
>  #endif
>  #include "mb862xxfb.h"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/