linux-kernel - Re: [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 May 2009 07:58:20 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
cc:	dsaxena@...xity.net, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 8250: Don't restore NS16550 mode when console suspend
 is disabled

On Wed, 13 May 2009, Alan Cox wrote:
> 
> Then hard coding is no improvement either. It needs to restore the mode
> that was present at suspend.

Alan, you're missing the fact that this is a special-case for "this is the 
console, and we're not suspending consoles AT ALL".

IOW, it was never suspended either, and it's a case that is known to be 
fundamentally buggy (we're suspending all the PCI bridges, but not a 
serial device that may be behind them!), but often work in _practice_ 
(because people don't use this thing for random serial devices, but for 
things like integrated serial lines that don't lose power).

So we _could_ just save the mode, but that isn't really what this patch is 
all about. The patch in question is about a total hack to avoid touching a 
piece of hardware that we simply don't consider normal.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/