linux-kernel - Re: [PATCH] da9030_battery: fix race between event handler and monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 May 2009 11:40:46 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mike Rapoport <mike@...pulab.co.il>
Cc:	cbou@...l.ru, linux-kernel@...r.kernel.org, mike@...pulab.co.il
Subject: Re: [PATCH] da9030_battery: fix race between event handler and
 monitor

On Tue, 12 May 2009 10:20:09 +0300
Mike Rapoport <mike@...pulab.co.il> wrote:

> Signed-off-by: Mike Rapoport <mike@...pulab.co.il>

We seem to be missing a changelog.

> 
> diff --git a/drivers/power/da9030_battery.c b/drivers/power/da9030_battery.c
> index 1662bb0..3364198 100644
> --- a/drivers/power/da9030_battery.c
> +++ b/drivers/power/da9030_battery.c
> @@ -22,8 +22,6 @@
>  #include <linux/debugfs.h>
>  #include <linux/seq_file.h>
>  
> -#define DA9030_STATUS_CHDET	(1 << 3)
> -
>  #define DA9030_FAULT_LOG		0x0a
>  #define DA9030_FAULT_LOG_OVER_TEMP	(1 << 7)
>  #define DA9030_FAULT_LOG_VBAT_OVER	(1 << 4)
> @@ -244,6 +242,8 @@ static void da9030_set_charge(struct da9030_charger *charger, int on)
>  	}
>  
>  	da903x_write(charger->master, DA9030_CHARGE_CONTROL, val);
> +
> +	power_supply_changed(&charger->psy);
>  }
>  
>  static void da9030_charger_check_state(struct da9030_charger *charger)
> @@ -258,6 +258,12 @@ static void da9030_charger_check_state(struct da9030_charger *charger)
>  			da9030_set_charge(charger, 1);
>  		}
>  	} else {
> +		/* Charger has been pulled out */
> +		if (!charger->chdet) {
> +			da9030_set_charge(charger, 0);
> +			return;
> +		}
> +
>  		if (charger->adc.vbat_res >=
>  		    charger->thresholds.vbat_charge_stop) {
>  			da9030_set_charge(charger, 0);
> @@ -395,13 +401,11 @@ static int da9030_battery_event(struct notifier_block *nb, unsigned long event,
>  {
>  	struct da9030_charger *charger =
>  		container_of(nb, struct da9030_charger, nb);
> -	int status;
>  
>  	switch (event) {
>  	case DA9030_EVENT_CHDET:
> -		status = da903x_query_status(charger->master,
> -					     DA9030_STATUS_CHDET);
> -		da9030_set_charge(charger, status);
> +		cancel_delayed_work_sync(&charger->work);
> +		schedule_work(&charger->work.work);
>  		break;
>  	case DA9030_EVENT_VBATMON:
>  		da9030_battery_vbat_event(charger);
> @@ -565,7 +569,8 @@ static int da9030_battery_remove(struct platform_device *dev)
>  	da903x_unregister_notifier(charger->master, &charger->nb,
>  				   DA9030_EVENT_CHDET | DA9030_EVENT_VBATMON |
>  				   DA9030_EVENT_CHIOVER | DA9030_EVENT_TBAT);
> -	cancel_delayed_work(&charger->work);
> +	cancel_delayed_work_sync(&charger->work);
> +	da9030_set_charge(charger, 0);
>  	power_supply_unregister(&charger->psy);
>  
>  	kfree(charger);

What is this race?  What are the user-visible effects when it occurs? 
How does the patch fix the race?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/