linux-kernel - [PATCH] reiserfs: xattr - Kill warning if !CONFIG_REISERFS_FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 16 May 2009 18:58:16 +0200 (CEST)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Jeff Mahoney <jeffm@...e.com>, Al Viro <viro@...iv.linux.org.uk>
cc:	reiserfs-devel@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: [PATCH] reiserfs: xattr - Kill warning if !CONFIG_REISERFS_FS_XATTR

If CONFIG_REISERFS_FS_XATTR is not set, I get:

    fs/reiserfs/xattr.c: In function 'reiserfs_xattr_init':
    fs/reiserfs/xattr.c:993: warning: unused variable 'privroot'

since commit ab17c4f02156c4f75d7fa43a5aa2a7f942d47201 ("reiserfs: fixup
xattr_root caching").

Move the definition of `privroot' inside the section protected by #ifdef
CONFIG_REISERFS_FS_XATTR to kill the warning.

Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
---
 fs/reiserfs/xattr.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
index 2237e10..3c767d9 100644
--- a/fs/reiserfs/xattr.c
+++ b/fs/reiserfs/xattr.c
@@ -990,9 +990,10 @@ int reiserfs_lookup_privroot(struct super_block *s)
 int reiserfs_xattr_init(struct super_block *s, int mount_flags)
 {
 	int err = 0;
-	struct dentry *privroot = REISERFS_SB(s)->priv_root;
 
 #ifdef CONFIG_REISERFS_FS_XATTR
+	struct dentry *privroot = REISERFS_SB(s)->priv_root;
+
 	err = xattr_mount_check(s);
 	if (err)
 		goto error;
-- 
1.6.3

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/