linux-kernel - Re: [PATCH/RFC 2.6.29.2] Driver for CB710/720 memory card reader (MMC part)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 May 2009 21:04:06 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Pierre Ossman <pierre@...man.eu>
Cc:	Michał Mirosław <mirq@...e.qmqm.pl>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH/RFC 2.6.29.2] Driver for CB710/720 memory card reader (MMC part) - v4

On Friday 22 May 2009 13:27:55 Pierre Ossman wrote:
> On Fri, 8 May 2009 17:16:22 +0200
> Michał Mirosław <mirq@...e.qmqm.pl> wrote:
> 
> > Here is next version of the CB710 SD/MMC reader driver. As in previous
> > versions the code is divided in two parts - virtual 'bus' driver that
> > handles PCI device and registers three new devices one per card reader
> > type. The other device handles SD/MMC part of the reader.
> > 
> > Key changes from v3:
> >  - kerneldoc for sg_mapping_iterator extension
> >  - free/restore IRQ during suspend/resume
> >  - protect slot->irq_handler by spinlock instead of RCU
> >  - remove verify_serialization()
> >  - Kconfig
> >  - complete patch for linux kernel 2.6.29.2
> > 
> 
> Looks good to me. I just want you to add a MAINTAINERS entry so that
> people know who to contact if they have problems with this driver.
> 
> > My patches for sg_mapping_iterator extension went to /dev/null, so I have
> > incorporated them to the cb710 core driver module for now. Probably someone
> > with more karma points should look at them (sgbuf2.{c,h}) and push further
> > if they are of any value to other driver writers.

I like the general idea and I think that this could serve as a good starting
point into making generic PIO handling library (which has been on my personal
TODO of things to look into for a long time).

Michał, I'll try ping you back about it once I'm done with 2.6.31 IDE stuff..

> Give them to Andrew Morton. He's good at finding the right people and
> making sure they notice. :)

Hehe, please keep me on cc:.

Thanks.
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/