lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 May 2009 05:35:00 +0200 From: Oleg Nesterov <oleg@...hat.com> To: Roland McGrath <roland@...hat.com> Cc: Christoph Hellwig <hch@...radead.org>, Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org Subject: Re: [RFC PATCH 7/X] ptrace: mv task->parent ptrace_task->pt_tracer On 05/27, Roland McGrath wrote: > > If you're going to zero out fields in a corner case, I think you should > zero si_code too Well, SI_USER == 0, so si_code is zero. And SI_USER looks more consistent to me, because > so it's consistent with what collect_signal() produces > when a signal is posted with OOM for the sigq allocation. perhaps it is better to change collect_signal() to set SI_USER ? Note that __send_signal() user SI_USER, not zero in is_si_special() case. > (It is likely nobody will ever see this path anyway, > since we'll probably merge the clean-up that replaces it before any release > that uses this series at all.) Yes! But without some fix, I was really puzzled how I can make any progress now. You never know which change will take most time... Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists