linux-kernel - RE: [PATCH v2 02/11] async_tx: kill ASYNC_TX_DEP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 29 May 2009 14:41:39 +0100
From:	"Sosnowski, Maciej" <maciej.sosnowski@...el.com>
To:	"Williams, Dan J" <dan.j.williams@...el.com>
CC:	"neilb@...e.de" <neilb@...e.de>,
	"linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
	"maan@...temlinux.org" <maan@...temlinux.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"yur@...raft.com" <yur@...raft.com>,
	"hpa@...or.com" <hpa@...or.com>
Subject: RE: [PATCH v2 02/11] async_tx: kill ASYNC_TX_DEP_ACK flag

Dan Williams wrote:
> In support of inter-channel chaining async_tx utilizes an ack flag to
> gate whether a dependent operation can be chained to another.  While the
> flag is not set the chain can be considered open for appending.  Setting
> the ack flag closes the chain and flags the descriptor for garbage
> collection.  The ASYNC_TX_DEP_ACK flag essentially means "close the
> chain after adding this dependency".  Since each operation can only have
> one child the api now implicitly sets the ack flag at dependency
> submission time.  This removes an unnecessary management burden from
> clients of the api.
> 
> [ Impact: clean up and enforce one dependency per operation ]
> 
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> ---
>  crypto/async_tx/async_memcpy.c |    2 +-
>  crypto/async_tx/async_memset.c |    2 +-
>  crypto/async_tx/async_tx.c     |    4 ++--
>  crypto/async_tx/async_xor.c    |    6 ++----
>  drivers/md/raid5.c             |   25 +++++++++++--------------
>  include/linux/async_tx.h       |    4 +---
>  6 files changed, 18 insertions(+), 25 deletions(-)

Async-tx-api.txt documentation should be also updated
(it still describes ASYNC_TX_DEP_ACK usage).

Acked-by: Maciej Sosnowski <maciej.sosnowski@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/