lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 May 2009 13:21:13 +0800 From: Balbir Singh <balbir@...ux.vnet.ibm.com> To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> Cc: Daisuke Nishimura <nishimura@....nes.nec.co.jp>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "hugh.dickins@...cali.co.uk" <hugh.dickins@...cali.co.uk>, "hannes@...xchg.org" <hannes@...xchg.org>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org> Subject: Re: [PATCH 1/4] add swap cache interface for swap reference v2 (updated) * KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> [2009-05-29 14:37:58]: > On Fri, 29 May 2009 14:08:32 +0900 > KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote: > > > IIUC, swap_free() at the end of shmem_writepage() should also be changed to swapcache_free(). > > > > > Hmm!. Oh, yes. shmem_writepage()'s error path. Thank you. It will be fixed. > > > here. > > == > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> > > In following patch, usage of swap cache will be recorded into swap_map. > This patch is for necessary interface changes to do that. > > 2 interfaces: > - swapcache_prepare() > - swapcache_free() > is added for allocating/freeing refcnt from swap-cache to existing > swap entries. But implementation itself is not changed under this patch. > At adding swapcache_free(), memcg's hook code is moved under swapcache_free(). > This is better than using scattered hooks. > > Changelog: v1->v2 > - fixed shmem_writepage() error path. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> Looks good to me so far Acked-by: Balbir Singh <balbir@...ux.vnet.ibm.com> -- Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists