linux-kernel - Fwd: BUG: Documentation/lguest/lguest.c bad paths for includes cause make to fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 31 May 2009 01:39:01 -0700
From:	"Charles 'Mack' Rhinelander" <mrhinelander@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Andrew Morton <akpm@...l.org>, lguest@...abs.org
Subject: Fwd: BUG: Documentation/lguest/lguest.c bad paths for includes cause 
	make to fail

---------- Forwarded message ----------
From: Charles 'Mack' Rhinelander <mrhinelander@...il.com>
Date: Sun, May 31, 2009 at 1:28 AM
Subject: BUG: Documentation/lguest/lguest.c bad paths for includes
cause make to fail
To: mm-commits@...r.kernel.org, kraai@...fs.org,
rusty@...tcorp.com.au, Andi Kleen <ak@...e.de>, Thomas Gleixner
<tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>


2.6.28-rc2-mm1 make fails at Documentation/lguest/lguest.c  Two
includes have bad paths: line 34 #include <zlib.h> (maybe should be
linux/zlib.h?), and line 47 #include "asm-x86/bootparam.h"

Are incorrect paths related to this recent gitignore of lguest.c (see
first cut below)?

asm-x86 has no bootparam.h; is this related to 2007 mm-commit list
concerning "allow asm-x86 to be included from userspace?" (see second
cut below)

---BEGIN CUT ABOUT gitignore OF lguest.c---

Gitweb:     http://git.kernel.org/linus/9536c26b31ae34ba6371a1b8f406028e9756f913
Commit:     9536c26b31ae34ba6371a1b8f406028e9756f913
Parent:     84a139a985300901dfad99bd93c7345d180af860
Author:     Matt Kraai <kraai@...fs.org>
AuthorDate: Thu Apr 16 23:46:20 2009 -0700
Committer:  Rusty Russell <rusty@...tcorp.com.au>
CommitDate: Sun Apr 19 23:14:02 2009 +0930

   lguest: tell git to ignore Documentation/lguest/lguest

   This is the example lguest launcher binary.

   Signed-off-by: Matt Kraai <kraai@...fs.org>
   Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
---
 Documentation/lguest/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Documentation/lguest/.gitignore b/Documentation/lguest/.gitignore
---END CUT---

---BEGIN CUT ABOUT allow x86 bootparam include from userspace---
List:       linux-mm-commits
Subject:    - make-asm-x86-bootparamh-includable-from-userspace.patch
removed from -mm tree
From:       akpm () linux-foundation ! org
Date:       2007-10-18 6:05:37

The patch titled
    Make asm-x86/bootparam.h includable from userspace
has been removed from the -mm tree.  Its filename was
    make-asm-x86-bootparamh-includable-from-userspace.patch

This patch was dropped because because of rejects

------------------------------------------------------
Subject: Make asm-x86/bootparam.h includable from userspace
From: Rusty Russell <rusty@...tcorp.com.au>

To actually write a bootloader (or, say, the lguest launcher) currently
requires duplication of these structures.  Making them includeable from
userspace is much nicer.

We merge the common userspace-required definitions of e820_32/64.h into e820.h
for export.

Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
Cc: Andi Kleen <ak@...e.de>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Ingo Molnar <mingo@...e.hu>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org
---END CUT---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/