linux-kernel - Re: [PATCH 3/4] gcov: add gcov profiling infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Jun 2009 12:34:44 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, andi@...stfloor.org,
	ying.huang@...el.com, W.Li@....COM, mingo@...e.hu,
	heicars2@...ux.vnet.ibm.com, mschwid2@...ux.vnet.ibm.com
Subject: Re: [PATCH 3/4] gcov: add gcov profiling infrastructure

On Tue, 2009-06-02 at 15:03 -0700, Andrew Morton wrote:
> On Tue, 02 Jun 2009 13:44:02 +0200
> Peter Oberparleiter <oberpar@...ux.vnet.ibm.com> wrote:

> > +void __gcov_init(struct gcov_info *info)
> > +{
> > +	static unsigned int gcov_version;
> > +
> > +	mutex_lock(&gcov_lock);
> > +	if (gcov_version == 0) {
> > +		gcov_version = info->version;
> > +		/*
> > +		 * Printing gcc's version magic may prove useful for debugging
> > +		 * incompatibility reports.
> > +		 */
> > +		pr_info("version magic: 0x%x\n", gcov_version);
> 
> Will this be spat out as simply
> 
> version magic: 0x1234
> 
> ?  If so, that'll be rather obscure because people won't know what
> subsystem printed it.  Prefixing this (and all other printks) with
> "gcov: " would fix that.

Great minds think alike, see a few lines above:

+#define pr_fmt(fmt)	"gcov: " fmt

cheers


Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)