linux-kernel - Re: add bcm47xx watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Jun 2009 16:58:42 +0200
From:	castet.matthieu@...e.fr
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	matthieu castet <castet.matthieu@...e.fr>, wim@...ana.be,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-mips@...ux-mips.org,
	Aleksandar Radovanovic <biblbroks@...ampro.rs>
Subject: Re: add bcm47xx watchdog driver

Hi Florian,

Quoting Florian Fainelli <florian@...nwrt.org>:

>
> Your driver looks good, could you turn this into a platform device/driver
> instead ? You declare bcm47xx_wdt_platform_device which is unused and you
> also declare a MODULE_ALIAS which suggets it is one.
What's the advantage of using platform device/driver ?
Not all watchdog driver use it (for example softdog).
This seems useless in this case because the driver don't have any resource,
don't care about suspend/resume and add complexity in the code (2 registers in
module probe, ...).


Matthieu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/