linux-kernel - Re: add bcm47xx watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Jun 2009 22:03:49 +0200
From:	matthieu castet <castet.matthieu@...e.fr>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	wim@...ana.be, linux-kernel@...r.kernel.org,
	linux-mips@...ux-mips.org, biblbroks@...ampro.rs
Subject: Re: add bcm47xx watchdog driver

Andrew Morton wrote:
> On Thu, 04 Jun 2009 22:24:56 +0200
> matthieu castet <castet.matthieu@...e.fr> wrote:
> 
>> This add watchdog driver for broadcom 47xx device.
>> It uses the ssb subsytem to access embeded watchdog device.
>>
>> ...
>>
>> --- linux-2.6.orig/drivers/watchdog/Kconfig	2009-05-25 22:22:02.000000000 +0200
>> +++ linux-2.6/drivers/watchdog/Kconfig	2009-05-25 22:26:06.000000000 +0200
>> @@ -764,6 +764,12 @@
>>  	help
>>  	  Hardware driver for the built-in watchdog timer on TXx9 MIPS SoCs.
>>  
>> +config BCM47XX_WDT
>> +    tristate "Broadcom BCM47xx Watchdog Timer"
>> +    depends on BCM47XX
>> +    help
>> +      Hardware driver for the Broadcom BCM47xx Watchog Timer.
> 
> Shouldn't there be some SSB dependencies in Kconfig here?
No, because :
config BCM47XX
     bool "BCM47XX based boards"
[...]
     select SSB
     select SSB_DRIVER_MIPS
     select SSB_DRIVER_EXTIF
     select SSB_EMBEDDED
     select SSB_PCICORE_HOSTMODE if PCI
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/