[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 06 Jun 2009 15:51:32 +0530
From: Jaswinder Singh Rajput <jaswinder@...nel.org>
To: Ingo Molnar <mingo@...e.hu>
Cc: Alan Cox <alan@...rguk.ukuu.org.uk>,
x86 maintainers <x86@...nel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: cpu_debug.c prepare report if files are
inappropriate or CPU is not supported
On Fri, 2009-06-05 at 23:27 +0530, Jaswinder Singh Rajput wrote:
> Hello Ingo,
>
> On Wed, 2009-04-15 at 12:17 +0200, Ingo Molnar wrote:
>
> > The main beef i had with your code is that it copies CPU enumeration
> > over into some local variables (cpu_modelflag, cpu_model) with
> > redundant encodings and decodings which dont fully work.
> >
> > Is there anything that your encoding/decoding does that cannot be
> > done via the standard methods?
> >
>
> I removed cpu model info. May be this will create some issues on ancient
> machine as now it depends on rdmsr_safe_on_cpu() and I hope it will be
> safe ;-)
> Can you please check this patch on ancient and latest machines.
>
>
> [PATCH] x86: cpu_debug remove model information to reduce encoding-decoding
>
> Remove model information, encoding/decoding and reduce bookkeeping.
>
> Reported-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
If you have any objections please let me know otherwise I will start
sending patches on top of this patch.
Thanks,
--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists