linux-kernel - Re: [PATCH] tracing/branch-tracer: PROFILE_BRANCHES_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 6 Jun 2009 16:56:28 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] tracing/branch-tracer: PROFILE_BRANCHES_PER_CPU must
	depend on SMP

On Sat, Jun 06, 2009 at 10:42:29AM -0400, Steven Rostedt wrote:
> 
> On Sat, 6 Jun 2009, Frederic Weisbecker wrote:
> > 
> > [ Impact: fix a build failure with the branch tracer ]
> > 
> > Reported-by: Ingo Molnar <mingo@...e.hu>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> > ---
> >  kernel/trace/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> > index 309a264..0efbcc5 100644
> > --- a/kernel/trace/Kconfig
> > +++ b/kernel/trace/Kconfig
> > @@ -285,7 +285,7 @@ endchoice
> >  
> >  config PROFILE_BRANCHES_PER_CPU
> >  	bool "Profile branches on a per cpu basis"
> > -	depends on PROFILE_ALL_BRANCHES
> > +	depends on PROFILE_ALL_BRANCHES && SMP
> 
> You just wasted two minutes of my time!
> 
> I was just about to send out the same patch, but you beat me to it. ;-)
> 
> Acked-by: Steven Rostedt <rostedt@...dmis.org>



We really need a mutex... ;-)

Frederic.


> 
> -- Steve
> 
> 
> >  	help
> >  	  When profiling all branches, the system can take a big cache line
> >  	  bouncing hit. On boxes with lots of CPUs, this can slow the system
> > -- 
> > 1.6.2.3
> > 
> > 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/