linux-kernel - Re: [sound] mpd loops on current -next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Jun 2009 18:37:11 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jaroslav Kysela <perex@...ex.cz>
Cc:	Jiri Slaby <jirislaby@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [sound] mpd loops on current -next

At Sat, 6 Jun 2009 17:52:44 +0200 (CEST),
Jaroslav Kysela wrote:
> 
> On Sat, 6 Jun 2009, Jiri Slaby wrote:
> 
> > Hi,
> >
> > I found a regression in current -next caused by
> > c44941e05900fe85f6091456f9e313b446a97ae9
> > (PCM midlevel: Do not update hw_ptr_jiffies when hw_ptr is not changed)
> 
> Oops. It seems like typo. Could you try this patch, please?

Ah, that's the cause of the bug with PA on the recent driver.
I didn't experience the problem because I myself don't use PA :)

Now merged to sound git tree.


thanks,

Takashi

> 
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index dd9126b..bf34603 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -371,7 +371,7 @@ int snd_pcm_update_hw_ptr(struct snd_pcm_substream *substream)
>   	    runtime->silence_size > 0)
>   		snd_pcm_playback_silence(substream, new_hw_ptr);
> 
> -	if (runtime->status->hw_ptr != new_hw_ptr)
> +	if (runtime->status->hw_ptr == new_hw_ptr)
>   		return 0;
> 
>   	runtime->hw_ptr_base = hw_base;
> 
>  					Thanks,
>  						Jaroslav
> 
> -----
> Jaroslav Kysela <perex@...ex.cz>
> Linux Kernel Sound Maintainer
> ALSA Project, Red Hat, Inc.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/