lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 6 Jun 2009 09:25:34 +0200
From:	Corentin Chary <corentin.chary@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Pekka J Enberg <penberg@...helsinki.fi>,
	acpi4asus-user@...ts.sourceforge.net, len.brown@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eeepc-laptop: enable camera by default

On Fri, Jun 5, 2009 at 10:08 PM, Andrew Morton<akpm@...ux-foundation.org> wrote:
> On Fri, 5 Jun 2009 11:59:41 +0300 (EEST)
> Pekka J Enberg <penberg@...helsinki.fi> wrote:
>
>>  /*
>> + * Camera helpers
>> + */
>> +
>> +static void eeepc_enable_camera(void)
>> +{
>> +     int err;
>> +
>> +     err = set_acpi(CM_ASL_CAMERA, 1);
>> +     if (err)
>> +             printk(EEEPC_WARNING "Unable to enable camera %d\n", err);
>> +}
>> +
>> +/*
>>   * Sys helpers
>>   */
>>  static int parse_arg(const char *buf, unsigned long count, int *val)
>> @@ -996,6 +1009,9 @@ static int __init eeepc_laptop_init(void)
>
> We can do this:
>
> --- a/drivers/platform/x86/eeepc-laptop.c~eeepc-laptop-enable-camera-by-default-fix
> +++ a/drivers/platform/x86/eeepc-laptop.c
> @@ -334,7 +334,7 @@ static const struct rfkill_ops eeepc_rfk
>  * Camera helpers
>  */
>
> -static void eeepc_enable_camera(void)
> +static void __init eeepc_enable_camera(void)
>  {
>        int err;
>
> _
>
> if we're so inclined?
>

Right, thanks, fixed patch pushed into acpi4asus.

-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ