[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 6 Jun 2009 09:14:53 +0100
From: Russell King <rmk+lkml@....linux.org.uk>
To: Sam Ravnborg <sam@...nborg.org>
Cc: Arnd Bergmann <arnd@...db.de>,
linux-kbuild <linux-kbuild@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Jaswinder Singh Rajput <jaswinder@...nel.org>
Subject: Re: [PATCH 17/39] kbuild: fix header export when __ASSEMBLY__ is
used
On Sat, Jun 06, 2009 at 08:05:52AM +0200, Sam Ravnborg wrote:
> On Sat, Jun 06, 2009 at 12:41:07AM +0000, Arnd Bergmann wrote:
> > On Friday 05 June 2009 11:42:35 pm Sam Ravnborg wrote:
> > > Because it does not know __ASSEMBLY__ it does not
> > > detect that htis is not for userspace.
> > > This caused too much code to be exported, and headers_check barfed
> > > over this code.
> > >
> > > For arm this fixes following "make headers_check" warning:
> > > /usr/include/asm/hwcap.h:29: extern's make no sense in userspace
> >
> > Are you sure that this is safe for all user space? If a user application
> > for instance includes asm/signal.h or asm/types.h from assembly (for
> > whatever reason), it now breaks.
>
> I had not thought about this implication.
> I will drop the patch as this most likely
> will break some userspace.
So now go back and re-read my original email. I was not suggesting to
undefine __ASSEMBLY__ - I was more detailed in my _question_ which I
was making, and there were _two_ possibilities.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists