linux-kernel - Re: [TRIVIAL][PATCH 1/1] Fix warning in staging/otus/ioctl.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 08 Jun 2009 11:09:52 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Pranith Kumar <pranith.hacks@...il.com>
CC:	greg@...ah.com, linux-kernel@...r.kernel.org
Subject: Re: [TRIVIAL][PATCH 1/1] Fix warning in staging/otus/ioctl.c

Pranith Kumar wrote:
> @@ -629,7 +629,7 @@ void  update_os_packet_info(
>  	pOSPkt->dev = get_netdev_from_bssid(pAd, FromWhichBSSID);
>  	pOSPkt->data = pRxBlk->pData;
>  	pOSPkt->len = pRxBlk->DataSize;
> -	pOSPkt->tail = pOSPkt->data + pOSPkt->len;
> +	pOSPkt->tail = (UCHAR *) (pOSPkt->data + pOSPkt->len);
>  }
>  
>  

This is what I meant with "a warning should stay there as long as the
underlying problem isn't fixed".

This code uses defined types which are foreign to Linux.  We don't
define UCHAR in Linux.  /This/ needs to be fixed in the entire driver.
Until this is not done, there is no reason to add this pointer type cast
merely to quieten gcc.
-- 
Stefan Richter
-=====-==--= -==- -=---
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/