linux-kernel - Re: 2.6.30 enabling cpu1 on resume fails after suspend to memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Jun 2009 14:37:08 +0200
From:	"Benjamin S." <sbenni@....de>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, js@...21.net,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	Matthew Wilcox <matthew@....cx>
Subject: Re: 2.6.30 enabling cpu1 on resume fails after suspend to memory

On Sun, 14 Jun 2009 14:15:16 +0200
"Rafael J. Wysocki" <rjw@...k.pl> wrote:

> On Sunday 14 June 2009, Thomas Gleixner wrote:
> > On Sun, 14 Jun 2009, Rafael J. Wysocki wrote:
> > > Evidently, the change of the interrupt handling during suspend-resume,
> > > commit 2ed8d2b3a81bdbb0418301628ccdb008ac9f40b7 (PM: Rework handling of
> > > interrupts during suspend-resume) broke resume (specifically, the enabling of
> > > nonboot CPUs) on the Benjamin's machine, but only if MSI support is enabled.
> > > Also, resume works if suspend_device_irqs() and resume_device_irqs() in
> > > drivers/base/power/main.c are commented out.
> > > 
> > > Is there anything the MSI code does in __enable_irq() and/or __disable_irq()
> > > that might cause this problem to appear?
> > 
> > Not that I'm aware of. Which of the devices is using MSI ? Have to
> > tried to skip only the MSI ones in suspend/resume_device_irqs() ?
> 
> Good idea.
> 
> Benjamin, please send /proc/interrupts from your system.

I guess it does not matter if from 2.6.29.2 or from 2.6.30. This 
is from 2.6.29.2 with CONFIG_PCI_MSI set:

           CPU0       CPU1       
  0:         42          1   IO-APIC-edge      timer
  1:          0         81   IO-APIC-edge      i8042
  6:          0          5   IO-APIC-edge      floppy
  8:          0          1   IO-APIC-edge      rtc0
  9:          0          0   IO-APIC-fasteoi   acpi
 14:          0        328   IO-APIC-edge      ide0
 15:          0          0   IO-APIC-edge      ide1
 16:          2        408   IO-APIC-fasteoi   ohci_hcd:usb1, ohci_hcd:usb3, HDA Intel
 17:          0          3   IO-APIC-fasteoi   ehci_hcd:usb2
 18:          0          0   IO-APIC-fasteoi   ohci_hcd:usb5, ohci_hcd:usb6, ohci_hcd:usb7
 19:          0         17   IO-APIC-fasteoi   ehci_hcd:usb4, HDA Intel
 24:       4830          0  HPET_MSI-edge      hpet2
 26:          0        135   PCI-MSI-edge      eth0
 27:          0       2855   PCI-MSI-edge      ahci
NMI:          0          0   Non-maskable interrupts
LOC:         42       5070   Local timer interrupts
RES:       2634       2170   Rescheduling interrupts
CAL:         72        104   Function call interrupts
TLB:        367        198   TLB shootdowns
TRM:          0          0   Thermal event interrupts
THR:          0          0   Threshold APIC interrupts
SPU:          0          0   Spurious interrupts
ERR:          0
MIS:          0

I am going to compile 2.6.30 with CONFIG_PCI_MSI again to ensure 
it is the same, but that will take some time.


Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/