linux-kernel - Re: [PATCH] LIB: remove unmatched write_lock() in gen_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Jun 2009 01:35:20 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Steve Wise <swise@...ngridcomputing.com>, zygo.blaxell@...dros.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LIB: remove unmatched write_lock() in gen_pool_destroy

On Tue, 16 Jun 2009 10:23:08 +0200 (CEST) Jiri Kosina <jkosina@...e.cz> wrote:

> On Mon, 15 Jun 2009, Andrew Morton wrote:
> 
> > > > this doesn't really qualify for trivial tree, as it introduces a 
> > > > significant code change. Adding some CCs.
> > > Looks ok to me.  Its dumb to aquire the lock you're gonna free anyway.  
> > > Maybe some BUG_ON() that sez nobody better be holding this lock?
> > CONFIG_DEBUG_OBJECTS_FREE could detect the freeing of a held rwlock. 
> > But probably it hasn't been wired up to handle rwlocks.
> 
> Hmm, in fact ... am I just completely blind, or is the only user of 
> CONFIG_DEBUG_OBJECTS_FREE the timer code?

Could be.  That infrastructure hasn't really been followed up on yet.

There's also CONFIG_DEBUG_LOCK_ALLOC which perhaps could/should be
implemented via debugobjects.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/