linux-kernel - [PATCH] Staging: s626: only claim some subsystem ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 17 Jun 2009 02:25:48 +0200 (CEST)
From:	Erik Inge Bolsø <knan-lkml@...uin.net>
To:	gregkh@...e.de
cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] Staging: s626: only claim some subsystem ids

Fix comedi s626 driver mistakenly binding to SAA7146 dvb cards, match only
the same subsystem ids the vendor reference driver s626 v1.0.1 does.

Signed-off-by: Erik Inge Bolsø <knan-lkml@...uin.net>
---
 drivers/staging/comedi/drivers/s626.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Looks obvious enough, but totally untested patch. Vendor driver consulted 
found from http://www.sensoray.com/products/626data.htm ... this driver 
looks to have been forked from it years ago, according to the source 
comments.

diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 30dec9d..5f1d373 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -111,7 +111,9 @@ static const struct s626_board s626_boards[] = {
 #define PCI_DEVICE_ID_S626 0x7146
 
 static DEFINE_PCI_DEVICE_TABLE(s626_pci_table) = {
-	{PCI_VENDOR_ID_S626, PCI_DEVICE_ID_S626, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+	{PCI_VENDOR_ID_S626, PCI_DEVICE_ID_S626, 0x6000, 0x0626, 0, 0,
+		0},
+	{PCI_VENDOR_ID_S626, PCI_DEVICE_ID_S626, 0x6000, 0x0272, 0, 0,
 		0},
 	{0}
 };
-- 
1.5.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/