linux-kernel - Re: linux-next: Tree for June 17 (pci/slot)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jun 2009 10:43:36 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
CC:	Matthew Wilcox <matthew@....cx>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Alex Chiang <achiang@...com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: linux-next: Tree for June 17 (pci/slot)

Jesse Barnes wrote:
> On Wed, 17 Jun 2009 10:36:04 -0600
> Matthew Wilcox <matthew@....cx> wrote:
> 
>> On Wed, Jun 17, 2009 at 09:26:51AM -0700, Randy Dunlap wrote:
>>> Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20090616:
>>>
>>> When CONFIG_SYSFS=n:
>>>
>>> drivers/pci/slot.c:327: error: 'module_kset' undeclared (first use
>>> in this function)
>> Is there any point to pci_slot existing without CONFIG_SYSFS?
>> I don't see how you can interact with it in any meaningful way.
>> Perhaps CONFIG_PCI_SLOT should depend on CONFIG_SYSFS?
> 
> I've got a code fix queued up, but maybe a Kconfig dependency is the
> way to go...

What is the code fix like?
The Kconfig fix makes sense to me.


-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/