linux-kernel - Re: [PATCH] New ASoC Drivers for ADI AD1938 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Jun 2009 12:13:36 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	Barry Song <21cnbao@...il.com>,
	"lrg@...mlogic.co.uk" <lrg@...mlogic.co.uk>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] New ASoC Drivers for ADI AD1938 codec

On 19 Jun 2009, at 12:05, Mike Frysinger <vapier.adi@...il.com> wrote:

> On Fri, Jun 19, 2009 at 06:47, Mark Brown wrote:
>> On Fri, Jun 19, 2009 at 05:28:15PM +0800, Barry Song wrote:
>>> 1. add AD1938 codec driver                   (codec)
>>> 2. add blackfin SPORT-TDM DAI and PCM driver (platform)
>>> 3. add bf5xx board with AD1938 driver        (machine)
>>
>> As Liam said you really need to submit this as a patch series rather
>> than as a single big patch - as your commit log here indicates you've
>> got several different things going on here.
>
> blah, i had this queued locally with a "todo:split".  wanted to wait
> for Barry to finish developing the driver first though.
>
> at any rate, i hate to sound like a broken record wrt my alsa
> ignorance, but i'm thinking the logical split would be like Barry
> numbered it -- one patch for sound/codec/, one patch for the TDM
> transport, and one patch for hooking up the AD1938 to TDM.

Yes, though if the new DAI format had been required it would be worth  
considering a separate patch for it.

>
>>> +static int __devinit ad1938_spi_probe(struct spi_device *spi)
>>> +{
>>> +     spi->dev.power.power_state = PMSG_ON;
>>> +     ad1938_socdev->card->codec->control_data = spi;
>>> +
>>> +     return 0;
>>> +}
>>> +
>>> +static int __devexit ad1938_spi_remove(struct spi_device *spi)
>>> +{
>>> +     return 0;
>>> +}
>>
>> Your device probing should all be restructured so that the SPI device
>> for the CODEC is registered as any other SPI device rather than being
>> set up as part of probing the ASoC device.  See the wm8731 driver for
>> an example of doing this for a SPI device.
>>
>> This will require that the arch code for any systems with the ad1938
>> do the setup of the device.
>
> so should sound/soc/blackfin/bf5xx-ad1938.c even exist in the first  
> place ?

Yes. It is needed in order to specify how things are hooked up on a  
given board.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/