| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Jun 2009 14:26:06 +0800
From: Gui Jianfeng <guijianfeng@...fujitsu.com>
To: Vivek Goyal <vgoyal@...hat.com>
CC: linux-kernel@...r.kernel.org,
containers@...ts.linux-foundation.org, dm-devel@...hat.com,
jens.axboe@...cle.com, nauman@...gle.com, dpshah@...gle.com,
lizf@...fujitsu.com, mikew@...gle.com, fchecconi@...il.com,
paolo.valente@...more.it, ryov@...inux.co.jp,
fernando@....ntt.co.jp, s-uchida@...jp.nec.com, taka@...inux.co.jp,
jmoyer@...hat.com, dhaval@...ux.vnet.ibm.com,
balbir@...ux.vnet.ibm.com, righi.andrea@...il.com,
m-ikeda@...jp.nec.com, jbaron@...hat.com, agk@...hat.com,
snitzer@...hat.com, akpm@...ux-foundation.org, peterz@...radead.org
Subject: Re: [PATCH 18/19] io-controller: Debug hierarchical IO scheduling
Vivek Goyal wrote:
...
> +static inline void bfq_account_for_entity_addition(struct io_entity *entity)
> +{
> + struct io_group *iog = io_entity_to_iog(entity);
> +
> + if (iog) {
> + struct elv_fq_data *efqd;
> + char path[128];
> +
> + /*
> + * Keep track of how many times a group has been removed
> + * from active tree because it did not have any active
> + * backlogged ioq under it
> + */
> + iog->queue++;
> + iog->queue_start = jiffies;
> +
> + /* Log group addition event */
> + rcu_read_lock();
> + efqd = rcu_dereference(iog->key);
> + if (efqd) {
> + io_group_path(iog, path, sizeof(path));
> + elv_log(efqd, "add group=%s weight=%ld", path,
> + iog->entity.weight);
Since cgroup path is already cached, why not use it. :)
Signed-off-by: Gui Jianfeng <guijianfeng@...fujitsu.com>
---
block/elevator-fq.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/block/elevator-fq.c b/block/elevator-fq.c
index bfa79c9..1a397c3 100644
--- a/block/elevator-fq.c
+++ b/block/elevator-fq.c
@@ -183,7 +183,6 @@ static inline void bfq_account_for_entity_addition(struct io_entity *entity)
if (iog) {
struct elv_fq_data *efqd;
- char path[128];
/*
* Keep track of how many times a group has been removed
@@ -197,9 +196,8 @@ static inline void bfq_account_for_entity_addition(struct io_entity *entity)
rcu_read_lock();
efqd = rcu_dereference(iog->key);
if (efqd) {
- io_group_path(iog, path, sizeof(path));
- elv_log(efqd, "add group=%s weight=%ld", path,
- iog->entity.weight);
+ elv_log(efqd, "add group=%s weight=%ld", iog->path,
+ iog->entity.weight);
}
rcu_read_unlock();
}
@@ -215,7 +213,6 @@ static inline void bfq_account_for_entity_deletion(struct io_entity *entity)
if (iog) {
struct elv_fq_data *efqd;
- char path[128];
iog->dequeue++;
/* Keep a track of how long group was on active tree */
@@ -227,9 +224,8 @@ static inline void bfq_account_for_entity_deletion(struct io_entity *entity)
rcu_read_lock();
efqd = rcu_dereference(iog->key);
if (efqd) {
- io_group_path(iog, path, sizeof(path));
- elv_log(efqd, "del group=%s weight=%ld", path,
- iog->entity.weight);
+ elv_log(efqd, "del group=%s weight=%ld", iog->path,
+ iog->entity.weight);
}
rcu_read_unlock();
}
--
1.5.4.rc3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists