linux-kernel - Re: [PATCH -tip] x86: mm/hugetlbpage.c fix style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Jun 2009 17:09:55 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Rohit Seth <rohitseth@...gle.com>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: mm/hugetlbpage.c fix style problems

On Sun, 2009-06-21 at 13:22 +0200, Ingo Molnar wrote:

> this change is not an improvement either.
> 
> Plus at a first glance that file has a couple of other problems as 
> well beyond trivial style issue:
> 
>  - dead code which should be removed
> 
>  - a 64-bit only boot option that should probably be extended to 
>    32-bit as well
> 
>  - insanely long function names with local scope, causing ugly 
>    linebreaks
> 
> and more style issues as well:
> 
>  - various inconsistent capitalizations in comment blocks
> 
>  - some other small details as well
> 
> Lets try to do a genuinely big and comprehensive forward step that 
> addresses all these issues (and any other issues that are in that 
> file), ok?
> 

ok, I will try.

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/