linux-kernel - Re: 2.6.30-git(16 and 17) system hangs after resume from suspend to disk, mce related?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Jun 2009 11:03:20 +0900
From:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
To:	Maciej Rutecki <maciej.rutecki@...il.com>
CC:	Andi Kleen <ak@...ux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>, "Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: 2.6.30-git(16 and 17) system hangs after resume from suspend
 to 	disk, mce related?

Maciej Rutecki wrote:
>> Also a "a few minutes" suggest something might be going wrong
>> with the poll handler.  Does the problem still happen
>> with you use CONFIG_X86_NEW_MCE again, but before
>> resume do
>>
>> echo 0 > /sys/device/system/machinecheck/machinecheck0/check_interval
>>
>> On the other hand you should get a crash very fast with
>>
>> echo 1 > /sys/device/system/machinecheck/machinecheck0/check_interval
> 
> I didn't instructions from above, but I found something else. After
> normal boot I try:
> 
> echo 1 > /sys/devices/system/machinecheck/machinecheck0/check_interval
> 
> I I found this in dmesg:
> 
> [  141.704025] ------------[ cut here ]------------
> [  141.704039] WARNING: at arch/x86/kernel/cpu/mcheck/mce.c:1102
> mcheck_timer+0xf5/0x100()

I see.  At least this warning will be cleared by following patch.
  WARN_ON(smp_processor_id() != data);

But I'm not sure whether this can cause system hangs or not.

Thanks,
H.Seto

===

[PATCH] x86, mce: percpu mcheck_timer should be pinned

Maciej Rutecki wrote:
> After normal boot I try:
> 
> echo 1 > /sys/devices/system/machinecheck/machinecheck0/check_interval
> 
> I I found this in dmesg:
> 
> [  141.704025] ------------[ cut here ]------------
> [  141.704039] WARNING: at arch/x86/kernel/cpu/mcheck/mce.c:1102
> mcheck_timer+0xf5/0x100()

If CONFIG_NO_HZ + CONFIG_SMP, timer added via add_timer() might
be migrated on other cpu.  Use add_timer_on() instead.

Reported-by: Maciej Rutecki <maciej.rutecki@...il.com>
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
CC: Andi Kleen <ak@...ux.intel.com>
---
 arch/x86/kernel/cpu/mcheck/mce.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 7da8fec..8e1794a 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1117,7 +1117,7 @@ static void mcheck_timer(unsigned long data)
 		*n = min(*n*2, (int)round_jiffies_relative(check_interval*HZ));
 
 	t->expires = jiffies + *n;
-	add_timer(t);
+	add_timer_on(t, smp_processor_id());
 }
 
 static void mce_do_trigger(struct work_struct *work)
@@ -1321,7 +1321,7 @@ static void mce_init_timer(void)
 		return;
 	setup_timer(t, mcheck_timer, smp_processor_id());
 	t->expires = round_jiffies(jiffies + *n);
-	add_timer(t);
+	add_timer_on(t, smp_processor_id());
 }
 
 /*
-- 
1.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/