linux-kernel - Re: [patch] Remove tty low_latency flag setting from drivers/char/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090622180650.1d5a6515@lxorguk.ukuu.org.uk>
Date:	Mon, 22 Jun 2009 18:06:50 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Chuck Ebbert <cebbert@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] Remove tty low_latency flag setting from drivers/char/

> Remove tty low_latency flag setting from drivers/char/.
> 
> The kernel oopses if this flag is set.

ipwireless_network_packet_received is not called from an IRQ path but
from a sleeping one. Please provide a trace of whatever you see failing
with that one as it should be fine and that isn't a bug fix. It may or
may not need low_latency but something else is wrong if it matters.

> 
> Signed-off-by: Chuck Ebbert <cebbert@...hat.com>
> 
> --- linux-2.6.30.noarch.orig/drivers/char/nozomi.c
> +++ linux-2.6.30.noarch/drivers/char/nozomi.c
> @@ -1591,8 +1591,6 @@ static int ntty_open(struct tty_struct *
>  
>  	/* Enable interrupt downlink for channel */
>  	if (port->port.count == 1) {
> -		/* FIXME: is this needed now ? */
> -		tty->low_latency = 1;

This one is correct.

> --- linux-2.6.30.noarch.orig/drivers/char/mxser.c
> +++ linux-2.6.30.noarch/drivers/char/mxser.c
> @@ -1048,8 +1048,6 @@ static int mxser_open(struct tty_struct 
>  	if (retval)
>  		return retval;
>  
> -	/* unmark here for very high baud rate (ex. 921600 bps) used */
> -	tty->low_latency = 1;
>  	return 0;
>  }

As is this
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/