linux-kernel - Re: [PATCH] USB: isp1760: allow platform devices to customize devflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Jun 2009 09:46:25 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	gregkh@...e.de, bigeasy@...uxtronix.de,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Michael Hennerich <michael.hennerich@...log.com>,
	Bryan Wu <cooloney@...nel.org>
Subject: Re: [PATCH] USB: isp1760: allow platform devices to customize 
	devflags

On Tue, Jun 23, 2009 at 09:39, Ben Dooks wrote:
> On Tue, Jun 23, 2009 at 09:18:34AM -0400, Mike Frysinger wrote:
>> From: Michael Hennerich <michael.hennerich@...log.com>
>>
>> Platform device support was merged earlier, but support for boards to
>> customize the devflags aspect of the controller was not.  We want this on
>> Blackfin systems to control the bus width, but might as well expose all of
>> the fields while we're at it.
>>
>> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
>> Signed-off-by: Bryan Wu <cooloney@...nel.org>
>> Signed-off-by: Mike Frysinger <vapier@...too.org>
>> ---
>>  drivers/usb/host/isp1760-hcd.c |    4 ++++
>>  drivers/usb/host/isp1760-hcd.h |    2 ++
>>  drivers/usb/host/isp1760-if.c  |   21 ++++++++++++++++++++-
>>  include/linux/usb/isp1760.h    |   18 ++++++++++++++++++
>>  4 files changed, 44 insertions(+), 1 deletions(-)
>>  create mode 100644 include/linux/usb/isp1760.h
>>
>> diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
>> index 1543846..9600a58 100644
>> --- a/drivers/usb/host/isp1760-hcd.c
>> +++ b/drivers/usb/host/isp1760-hcd.c
>> @@ -386,6 +386,10 @@ static int isp1760_hc_setup(struct usb_hcd *hcd)
>>               hwmode |= HW_DACK_POL_HIGH;
>>       if (priv->devflags & ISP1760_FLAG_DREQ_POL_HIGH)
>>               hwmode |= HW_DREQ_POL_HIGH;
>> +     if (priv->devflags & ISP1760_FLAG_INTR_POL_HIGH)
>> +             hwmode |= HW_INTR_HIGH_ACT;
>> +     if (priv->devflags & ISP1760_FLAG_INTR_EDGE_TRIG)
>> +             hwmode |= HW_INTR_EDGE_TRIG;
>
> better move these to the irq resource flags from the resource array
> in the platfrom device.

dont really know what you mean.  the setup() function is shared
between multiple bus types (pci/platform/...), so the bits cant really
be pushed from the setup() to the platform resources ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/