linux-kernel - Re: [RFC] O_NOACC: open without any access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Jun 2009 16:12:22 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	hch@...radead.org
CC:	miklos@...redi.hu, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	viro@...IV.linux.org.uk, adilger@....com, dhowells@...hat.com,
	alan@...rguk.ukuu.org.uk, akpm@...ux-foundation.org
Subject: Re: [RFC] O_NOACC: open without any access

On Tue, 23 Jun 2009, Christoph Hellwig wrote:
> we guarantee that f_op is never NULL, so you'll need to assign a
> file operations structure that is empty to it to avoid crashed in
> various places.

Yeah, the patch was just a proof of concept thing (and most places
still check f_op != NULL before dereferncing, so..)

> > It would be logical to reuse the open_flag=3 value, but that has
> > historically been used with different semantics so I'm afraid of
> > touching it.
> 
> I think the historical semantics are exactly that you can open it
> an issue ioctls + stat / etc on it ut not actually read/write it.

Two differences between open("foo", 3) and open("foo", O_NOACC):

  1) open with "3" requires _read_and_write_ permissions on foo, but
     does not allow either read or write.  Not sure what the logic in
     that, but that's the way it has always been.

  2) open with "3" calls driver's ->open() with any side effect that
     may have.  Open with O_NOACC doesn't do that, and hence if we
     want to allow ioctls they need a new interface which gets a
     "struct path" instead of a "struct file".

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/