linux-kernel - Re: [patch 3/6] ide: always kill the whole request on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Jun 2009 16:39:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	bzolnier@...il.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, petkovbb@...il.com, htejun@...il.com
Subject: Re: [patch 3/6] ide: always kill the whole request on error

From: Joe Perches <joe@...ches.com>
Date: Tue, 23 Jun 2009 16:37:54 -0700

> On Tue, 2009-06-23 at 16:19 -0700, David Miller wrote:
>> From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
>> Date: Tue, 23 Jun 2009 23:27:27 +0200
>> > From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
>> > Subject: [PATCH] ide: always kill the whole request on error
>> > --- a/drivers/ide/ide-eh.c
>> > +++ b/drivers/ide/ide-eh.c
>> > @@ -149,7 +149,7 @@ static inline void ide_complete_drive_re
>> >  	if (rq && blk_special_request(rq) && rq->cmd[0] == REQ_DRIVE_RESET) {
>> >  		if (err <= 0 && rq->errors == 0)
>> >  			rq->errors = -EIO;
>> > -		ide_complete_rq(drive, err ? err : 0, ide_rq_bytes(rq));
>> > +		ide_complete_rq(drive, err ? err : 0, blk_rq_bytes(rq));
> 
> Doesn't that "err ? err : 0" look odd?
> Why not just err?

These functions are full of surprises :-)

Yes, plain 'err' should be absolutely equivalent to what's
there right now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/