linux-kernel - Re: [RFC v5][PATCH 1/4] intel_txt: Intel(R) TXT boot support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 24 Jun 2009 20:44:09 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Joseph Cihula <joseph.cihula@...el.com>
cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, arjan@...ux.intel.com,
	hpa@...or.com, andi@...stfloor.org, chrisw@...s-sol.org,
	jbeulich@...ell.com, peterm@...hat.com, gang.wei@...el.com,
	shane.wang@...el.com
Subject: Re: [RFC v5][PATCH 1/4] intel_txt: Intel(R) TXT boot support

On Mon, 22 Jun 2009, Joseph Cihula wrote:


> +void tboot_copy_fadt(const struct acpi_table_fadt *fadt)
> +{
> +#define TB_COPY_GAS(tbg, g)			\
> +	tbg.space_id     = g.space_id;		\
> +	tbg.bit_width    = g.bit_width;		\
> +	tbg.bit_offset   = g.bit_offset;	\
> +	tbg.access_width = g.access_width;	\
> +	tbg.address      = g.address;
> +
> +	TB_COPY_GAS(tboot_shared->acpi_sinfo.pm1a_cnt_blk,
> +		    fadt->xpm1a_control_block);
> +	TB_COPY_GAS(tboot_shared->acpi_sinfo.pm1b_cnt_blk,
> +		    fadt->xpm1b_control_block);
> +	TB_COPY_GAS(tboot_shared->acpi_sinfo.pm1a_evt_blk,
> +		    fadt->xpm1a_event_block);
> +	TB_COPY_GAS(tboot_shared->acpi_sinfo.pm1b_evt_blk,
> +		    fadt->xpm1b_event_block);

Not a showstopper, but why not simply make a static tb_copy_gas() 
function?

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/