linux-kernel - Re: [PATCH 1/3] Return ENODEV instead of EINVAL when trying to open ACM device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Jun 2009 23:17:04 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>,
	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/3] Return ENODEV instead of EINVAL when trying to open ACM device.

Am Mittwoch, 24. Juni 2009 22:40:15 schrieb Greg KH:
> On Wed, Jun 24, 2009 at 08:31:15AM -0300, Thadeu Lima de Souza Cascardo wrote:
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
> > ---
> >  drivers/usb/class/cdc-acm.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> > index 38bfdb0..02eb60b 100644
> > --- a/drivers/usb/class/cdc-acm.c
> > +++ b/drivers/usb/class/cdc-acm.c
> > @@ -550,7 +550,7 @@ static void acm_waker(struct work_struct *waker)
> >  static int acm_tty_open(struct tty_struct *tty, struct file *filp)
> >  {
> >  	struct acm *acm;
> > -	int rv = -EINVAL;
> > +	int rv = -ENODEV;
>
> Why is this needed?

The current error return is incorrect. If the table entry is gone, the
device has been disconnected, hence -ENODEV.

	Regards
		Oliver
Acked-by: Oliver Neukum <oliver@...kum.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/