| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Jun 2009 06:13:56 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: Kay Sievers <kay.sievers@...y.org> Cc: Sergey Senozhatsky <sergey.senozhatsky@...l.by>, Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] kobject_set_name_vargs memory leak Kay Sievers <kay.sievers@...y.org> writes: > On Sun, Jun 28, 2009 at 14:07, Eric W. Biederman<ebiederm@...ssion.com> wrote: > >> But setting a kobject's name several times in a row is a bug. You >> need to call kobject_rename if you are going to change the name. > > Sure, we can define in that way. > >> So how about we fix the driver core not to do that. Stop treating fmt >> as a flag, and make it clear kobject_add should not be passed a name. > > Sounds fine to me. You did not try to compile your patch, right? :) Only the lib/kobject bits... > block/blk-sysfs.c: In function ‘blk_register_queue’: > block/blk-sysfs.c:436: error: implicit declaration of function ‘kobj_set_name’ > > drivers/base/driver.c: In function ‘driver_add_kobj’: > drivers/base/driver.c:149: error: too many arguments to function ‘kobject_add’ Ugh I totally missed that one. > Documentation/kobject.txt would also need an update then. As for the rules it already seems correct. But getting the prototype and mentioning kobject_set_name wouldn't hurt. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists