linux-kernel - Re: [PATCH 0/3] msm_sdcc: A few more cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Jun 2009 08:57:48 +0200
From:	Pavel Machek <pavel@....cz>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, pierre@...man.eu,
	swetland@...gle.com, Andrew Morton <akpm@...ux-foundation.org>,
	San Mehat <san@...gle.com>
Subject: Re: [PATCH 0/3] msm_sdcc: A few more cleanups

Hi!

> Perhaps these are appropriate as well.
> Uncompiled, I haven't set up an ARM cross compiler yet.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> Joe Perches (3):
>   msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>(
>   msm_sdcc.c: stylistic cleaning
>   msm_sdcc.c: Move overly indented code to separate function

They look good, but break compilation. With these fixes, it compiles &
boots. Thanks!

Signed-off-by: Pavel Machek <pavel@....cz>

diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 010f4f4..6644cda 100644
--- a/drivers/mmc/host/msm_sdcc.c
+++ b/drivers/mmc/host/msm_sdcc.c
@@ -321,7 +321,7 @@ msmsdcc_start_data(struct msmsdcc_host *host, struct mmc_data *data)
 	memset(&host->pio, 0, sizeof(host->pio));
 
 	clks = (unsigned long long)data->timeout_ns * host->clk_rate;
-	do_div(clks, NSECS_PER_SEC);
+	do_div(clks, NSEC_PER_SEC);
 	timeout = data->timeout_clks + (unsigned int)clks;
 	writel(timeout, base + MMCIDATATIMER);
 
@@ -588,6 +588,8 @@ static void
 msmsdcc_handle_irq_data(struct msmsdcc_host *host, struct mmc_data *data,
 			u32 status)
 {
+	void __iomem	*base = host->base;
+
 	/* Check for data errors */
 	if (status & (MCI_DATACRCFAIL | MCI_DATATIMEOUT | 
 		      MCI_TXUNDERRUN | MCI_RXOVERRUN)) {


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/