linux-kernel - Re: [PATCH 2/8] SFI: include/linux/sfi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Jun 2009 23:59:31 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	lenb@...nel.org, sfi-devel@...plefirmware.org,
	linux-kernel@...r.kernel.org, feng.tang@...el.com,
	len.brown@...el.com
Subject: Re: [PATCH 2/8] SFI: include/linux/sfi.h


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Tue, 23 Jun 2009 09:28:11 +0200
> Ingo Molnar <mingo@...e.hu> wrote:
> 
> > > +/*
> > > + * Table structures must be byte-packed to match the SFI specification,
> > > + * as they are provided by the BIOS.
> > > + */
> > > +#pragma pack(1)
> > 
> > We use __attribute__((packed)) for that generally.
> 
> Or __packed.  I usually recommend __packed because I can never 
> remember the weird arrangement of underscores and parentheses in 
> the gcc thing.

Agreed - it's also shorter and more in line with stuff like 
__read_mostly, etc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/