linux-kernel - Re: [PATCH 2/5] power_supply: fix up olpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 1 Jul 2009 02:57:52 +0400
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	Andres Salomon <dilinger@...labora.co.uk>
Cc:	cbou@...l.ru, dwmw2@...radead.org, linux-kernel@...r.kernel.org,
	richard@...top.org, Andrew Morton <akpm@...ux-foundation.org>,
	Paul Fox <pgf@...top.org>, dsaxena@...top.org
Subject: Re: [PATCH 2/5] power_supply: fix up olpc_battery's eeprom read
 function

On Tue, Jun 30, 2009 at 02:14:00AM -0400, Andres Salomon wrote:
> 
> The eeprom read function was placing values into the wrong place in
> 'buf'; we were starting from buf[off], rather than buf[0].
> 
> Also, the for loop that we were using was much uglier than it needed to
> be.  This cleans it up a bit.
> 
> Signed-off-by: Andres Salomon <dilinger@...labora.co.uk>

Applied to battery-2.6.31.git w/ some cosmtic changes.
Please ensure that everything is OK.

Thanks!

> ---
>  drivers/power/olpc_battery.c |   14 ++++++--------
>  1 files changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/power/olpc_battery.c b/drivers/power/olpc_battery.c
> index 0d1928d..d2df0db 100644
> --- a/drivers/power/olpc_battery.c
> +++ b/drivers/power/olpc_battery.c
> @@ -343,21 +343,19 @@ static ssize_t olpc_bat_eeprom_read(struct kobject *kobj,
>  		struct bin_attribute *attr, char *buf, loff_t off, size_t count)
>  {
>  	uint8_t ec_byte;
> -	int ret, end;
> +	int ret, i;
>  
>  	if (off >= EEPROM_SIZE)
>  		return 0;
>  	if (off + count > EEPROM_SIZE)
>  		count = EEPROM_SIZE - off;
>  
> -	end = EEPROM_START + off + count;
> -	for (ec_byte = EEPROM_START + off; ec_byte < end; ec_byte++) {
> -		ret = olpc_ec_cmd(EC_BAT_EEPROM, &ec_byte, 1,
> -				&buf[ec_byte - EEPROM_START], 1);
> +	for (i = 0; i < count; i++) {
> +		ec_byte = EEPROM_START + off + i;
> +		ret = olpc_ec_cmd(EC_BAT_EEPROM, &ec_byte, 1, &buf[i], 1);
>  		if (ret) {
> -			printk(KERN_ERR "olpc-battery:  EC command "
> -					"EC_BAT_EEPROM @ 0x%x failed -"
> -					" %d!\n", ec_byte, ret);
> +			printk(KERN_ERR "olpc-battery:  EC_BAT_EEPROM cmd @ 0x%x failed - %d!\n",
> +					ec_byte, ret);
>  			return -EIO;
>  		}
>  	}
> -- 
> 1.5.6.5
> 

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/