linux-kernel - Re: [PATCH 5/5] power_supply: add a charge_type status to the api, and use it for olpc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Jul 2009 03:14:50 +0400
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	Andres Salomon <dilinger@...labora.co.uk>
Cc:	cbou@...l.ru, dwmw2@...radead.org, linux-kernel@...r.kernel.org,
	richard@...top.org, Andrew Morton <akpm@...ux-foundation.org>,
	Paul Fox <pgf@...top.org>, dsaxena@...top.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH 5/5] power_supply: add a charge_type status to the api,
 and use it for olpc driver

On Tue, Jun 30, 2009 at 02:17:30AM -0400, Andres Salomon wrote:
> 
> This adds a new sysfs file called 'charge_type' which displays the type of
> charging (n/a, trickle charge, slow charge, or fast charging).  This allows
> things like battery diagnostics to determine what the battery/EC is doing
> without resorting to changing the 'status' sysfs output.
> 
> Signed-off-by: Andres Salomon <dilinger@...labora.co.uk>
> ---

The patch didn't apply cleanly (not sure why, maybe because
of my "cosmetic" changes in the previous patches? hm.)

Can you please add "Unknown" state before "N/A", and
per Mark's comments also remove "Slow" charge type, and
resend the patch against battery-2.6.git tree?

Mark, since you seem to be interested in this addition, it
would be great to see your ack/nak status on an updated
patch, so we'll be sure that this is suitable for WM8350.

Thanks!

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/