linux-kernel - Re: vfat creates multiple files with the same filename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Jul 2009 02:02:53 +0200 (CEST)
From:	Marton Balint <cus@...ekas.hu>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
cc:	linux-kernel@...r.kernel.org
Subject: Re: vfat creates multiple files with the same filename

On Tue, 30 Jun 2009, OGAWA Hirofumi wrote:
> Marton Balint <cus@...ekas.hu> writes:
> 
> > I don't know if removing the invalid characters silently instead of 
> > returning EINVAL is a good practice, but allowing two files with identical 
> > filenames is definitely wrong. 
> 
> The utf8 function seems didn't return the error for invalid char.
> 
> > Could someone please have a look at the problem? Unfortunately I am not 
> > qualified enough to track it down...
> >
> > I've run the testcase on both 2.6.30 and 2.6.31-rc1 kernels, but this bug 
> > is probably not very new, since I remember having it also in 2.6.27.
> 
> This is quick hack though, this should return -EINVAL for invalid char
> like nls.  Can you try this?

It works for me, filenames with invalid utf-8 characters are now rejected, 
so I no longer can create multiple files with the same name. Thanks for 
the fix.

Regards,
  Marton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/