linux-kernel - Re: [PATCH] FRV: Wire up new syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Jul 2009 16:49:13 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Howells <dhowells@...hat.com>
Cc:	Paul Mackerras <paulus@...ba.org>, Arnd Bergmann <arnd@...db.de>,
	torvalds@...l.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FRV: Wire up new syscalls


* David Howells <dhowells@...hat.com> wrote:

> Ingo Molnar <mingo@...e.hu> wrote:
> 
> > Yeah - still i'd suggest to just go with the generic code initially, 
> 
> Nah, that's no fun!  Besides, the code is very similar to the 32-bit code, and
> I'm fairly certain it'll work.  I can also check it very easily by dumping
> some temp test code in setup.c.
> 
> Anyway, I see the following errors:
> 
> kernel/perf_counter.c: In function 'perf_counter_index':
> kernel/perf_counter.c:1889: error: 'PERF_COUNTER_INDEX_OFFSET' undeclared (first use in this function)
> kernel/perf_counter.c:1889: error: (Each undeclared identifier is reported only once
> kernel/perf_counter.c:1889: error: for each function it appears in.)
>   CC      block/as-iosched.o
> kernel/perf_counter.c:1890: warning: control reaches end of non-void function

Ok, indeed - you can define it to 0 for now - FRV wont set hw 
counters so it doesnt matter. It is used for the hw index in the 
mmap head for 'direct' access to the PMU, using special instructions 
like RDPMC (on x86). Probably not relevant to FRV.

> But this symbol appears to be undocumented:
> 
> 	warthog>grep -r PERF_COUNTER_INDEX_OFFSET Documentation/
> 	warthog1>grep -r INDEX_OFFSET Documentation/
> 	warthog1>

You can use the power of the Git space:

   git log -SPERF_COUNTER_INDEX_OFFSET

:-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/