linux-kernel - Re: [PATCH 5/9] [RFC] Remove cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Jul 2009 02:32:27 -0700
From:	Paul Menage <menage@...gle.com>
To:	Louis.Rilling@...labs.com
Cc:	lizf@...fujitsu.com, balbir@...ux.vnet.ibm.com,
	containers@...ts.linux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/9] [RFC] Remove cgroup_subsys.root pointer

On Thu, Jul 2, 2009 at 2:04 AM, Louis Rilling<Louis.Rilling@...labs.com> wrote:
>> +/* Find the root for a given subsystem */
>> +static struct cgroupfs_root *find_root(struct cgroup_subsys *ss)
>> +{
>> +     int id = ss->subsys_id;
>> +     struct cgroupfs_root *root, *res = NULL;
>> +     for_each_root(root) {
>> +             if (root->subsys_bits && (1UL << id)) {
> Should be &, not && ------------------^^
>

Good catch. This is only used by cgroup_clone() via ns_cgroup, and I
hadn't done any testing with namespace creation and ns_cgroup.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/