linux-kernel - Re: [PATCH -tip] x86: Remove useless variable disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Jul 2009 21:14:23 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: Re: [PATCH -tip] x86: Remove useless variable disable_x2apic

[Jaswinder Singh Rajput - Thu, Jul 02, 2009 at 10:33:59PM +0530]
| 
| setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it.
| 
| Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
| ---
|  arch/x86/kernel/apic/apic.c |    2 --
|  1 files changed, 0 insertions(+), 2 deletions(-)
| 
| diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
| index 8c7c042..0a1c283 100644
| --- a/arch/x86/kernel/apic/apic.c
| +++ b/arch/x86/kernel/apic/apic.c
| @@ -140,7 +140,6 @@ int x2apic_mode;
|  #ifdef CONFIG_X86_X2APIC
|  /* x2apic enabled before OS handover */
|  static int x2apic_preenabled;
| -static int disable_x2apic;
|  static __init int setup_nox2apic(char *str)
|  {
|  	if (x2apic_enabled()) {
| @@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str)
|  		return 0;
|  	}
|  
| -	disable_x2apic = 1;
|  	setup_clear_cpu_cap(X86_FEATURE_X2APIC);
|  	return 0;
|  }
| -- 
| 1.6.2.5
|

yes, at moment we use cpu_has_x2apic mostly.
Ack. But lets CC Suresh to be sure. Maybe
there is something in plans.
 
	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/