| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Jul 2009 11:35:18 +0100 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Lars-Peter Clausen <lars@...afoo.de> Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ASoC: Fix wm8753 register cache size and initialization On Fri, Jul 03, 2009 at 12:15:45PM +0200, Lars-Peter Clausen wrote: > Mark Brown wrote: > >Only 62 of the registers are cached - please see the register cache > >access code. > Yes. Thats the problem. The register cache holds place for 62 > elements where as there are 63 register which should be cached. > In the register cache access code you subtract one from the > registers index to get it's index in the register cache array, so > the last register has the index 62. Which means it is the 63th > element of the array and thus the array has to consist of 63 > elements. OK, that makes sense. I will apply your patch with a rewritten commit message which explains the issue - the problem is not that there is one less register in the cache than is in use, it's that there is one less register in the cache than is *cached*. As I say the code deliberately doesn't cache one of the registers. > >I'm not 100% sure what you mean here but I suspect you're misreading the > >register cache access code? > The register cache access code uses one-based indexing so the first Right, that makes sense with the above. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists