linux-kernel - Re: [PATCH] IIO: Add missing I2C dependencies for max1363 and tsl2561

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jul 2009 21:13:48 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	linux-kernel@...r.kernel.org, chrisv@...erswitching.com,
	daniel@...aq.de, iws@...o.caltech.edu, dmitry.torokhov@...il.com,
	hmh@....eng.br, david-b@...bell.net
Subject: Re: [PATCH] IIO: Add missing I2C dependencies for max1363 and
 tsl2561

On Fri, 03 Jul 2009 17:12:13 +0000, Jonathan Cameron wrote:
> Signed-off-by: Jonathan Cameron <jic23@....ac.uk>
> 
> I will roll these into the original patches at some point, but
> for now they are here.
> 
> Thanks to David Brownell for spotting this.
> ---
>  drivers/iio/adc/Kconfig   |    2 +-
>  drivers/iio/light/Kconfig |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index cb773d2..ab2066c 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -6,7 +6,7 @@ comment "Analog to digital convertors"
>  
>  config MAX1363
>  	tristate "MAXIM max1363 ADC driver"
> -	depends on IIO
> +	depends on IIO && I2C
>  	help
>  	  Say yes here to build support for many MAXIM i2c analog to digital
>  	  convertors (ADC). (max1361, max1362, max1363, max1364, max1136,
> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
> index 620e249..62d502c 100644
> --- a/drivers/iio/light/Kconfig
> +++ b/drivers/iio/light/Kconfig
> @@ -6,7 +6,7 @@ comment "Light sensors"
>  
>  config TSL2561
>         tristate "TAOS TSL2561 light-to-digital convertor"
> -       depends on IIO
> +       depends on IIO && I2C
>         help
>  	Say yes bere to build support for the TAOS light to digital
>  	convertor.  This chip has two light sensors. One is broadband

Unrelated suggestion: you could surround all the driver configuration
entries with a big

if IIO

(...)

endif # IIO

This would save you the hassle of adding "depends on IIO" to every
driver. Many subsystems have resorted to this technique by now.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/